From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48786 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756272AbeEASeu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 1 May 2018 14:34:50 -0400
Date: Tue, 01 May 2018 14:34:47 -0400 (EDT)
Message-Id: <20180501.143447.737462619555001271.davem@davemloft.net>
To: soheil.kdev@gmail.com
Cc: netdev@vger.kernel.org, ycheng@google.com, ncardwell@google.com,
        edumazet@google.com, willemb@google.com, soheil@google.com
Subject: Re: [PATCH V3 net-next 1/2] tcp: send in-queue bytes in cmsg upon
 read
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180501141128.208705-1-soheil.kdev@gmail.com>
References: <20180501141128.208705-1-soheil.kdev@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
Date: Tue,  1 May 2018 10:11:27 -0400

> +static inline int tcp_inq_hint(struct sock *sk)

Please do not use 'inline' in foo.c files, let the compiler decide.

Otherwise looks great, thanks.