From: David Miller <davem@davemloft.net>
To: davejwatson@fb.com
Cc: andre@tomt.net, netdev@vger.kernel.org, borisp@mellanox.com,
aviadye@mellanox.com
Subject: Re: [PATCH net] net/tls: Don't recursively call push_record during tls_write_space callbacks
Date: Tue, 01 May 2018 19:02:57 -0400 (EDT) [thread overview]
Message-ID: <20180501.190257.1668323183142583789.davem@davemloft.net> (raw)
In-Reply-To: <20180501200539.GA69207@davejwatson-mba.dhcp.thefacebook.com>
From: Dave Watson <davejwatson@fb.com>
Date: Tue, 1 May 2018 13:05:39 -0700
> It is reported that in some cases, write_space may be called in
> do_tcp_sendpages, such that we recursively invoke do_tcp_sendpages again:
>
> [ 660.468802] ? do_tcp_sendpages+0x8d/0x580
> [ 660.468826] ? tls_push_sg+0x74/0x130 [tls]
> [ 660.468852] ? tls_push_record+0x24a/0x390 [tls]
> [ 660.468880] ? tls_write_space+0x6a/0x80 [tls]
> ...
>
> tls_push_sg already does a loop over all sending sg's, so ignore
> any tls_write_space notifications until we are done sending.
> We then have to call the previous write_space to wake up
> poll() waiters after we are done with the send loop.
>
> Reported-by: Andre Tomt <andre@tomt.net>
> Signed-off-by: Dave Watson <davejwatson@fb.com>
Applied.
next prev parent reply other threads:[~2018-05-01 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 20:05 [PATCH net] net/tls: Don't recursively call push_record during tls_write_space callbacks Dave Watson
2018-05-01 23:02 ` David Miller [this message]
2018-05-06 1:06 ` Andre Tomt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501.190257.1668323183142583789.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andre@tomt.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).