From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Toshiaki Makita <toshiaki.makita1@gmail.com>
Cc: brouer@redhat.com, netdev@vger.kernel.org,
Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Subject: Re: [PATCH RFC 4/9] veth: Use NAPI for XDP
Date: Tue, 1 May 2018 09:50:21 +0200 [thread overview]
Message-ID: <20180501095008.207c354f@brouer.com> (raw)
In-Reply-To: <20180424143923.26519-5-toshiaki.makita1@gmail.com>
On Tue, 24 Apr 2018 23:39:18 +0900
Toshiaki Makita <toshiaki.makita1@gmail.com> wrote:
> +static int veth_xdp_enqueue(struct veth_priv *priv, void *ptr)
> +{
> + if (unlikely(ptr_ring_produce(&priv->xdp_ring, ptr)))
> + return -ENOSPC;
> +
> + return 0;
> +}
Here we have a lock per (enqueued) packet. I'm working on changing the
ndo_xdp_xmit API to allow bulking. And the tun driver have exact same
issue/need.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-05-01 7:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 14:39 [PATCH RFC 0/9] veth: Driver XDP Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 1/9] net: Export skb_headers_offset_update and skb_copy_header Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 2/9] veth: Add driver XDP Toshiaki Makita
2018-04-25 20:39 ` Jesper Dangaard Brouer
2018-04-26 10:46 ` Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 3/9] veth: Avoid drops by oversized packets when XDP is enabled Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 4/9] veth: Use NAPI for XDP Toshiaki Makita
2018-05-01 7:50 ` Jesper Dangaard Brouer [this message]
2018-05-01 8:02 ` Toshiaki Makita
2018-05-01 8:43 ` Jesper Dangaard Brouer
2018-05-02 3:37 ` Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 5/9] veth: Handle xdp_frame in xdp napi ring Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 6/9] veth: Add ndo_xdp_xmit Toshiaki Makita
2018-04-25 20:24 ` Jesper Dangaard Brouer
2018-04-26 10:52 ` Toshiaki Makita
2018-04-30 17:27 ` Jesper Dangaard Brouer
2018-05-01 1:02 ` Toshiaki Makita
2018-05-01 8:14 ` Jesper Dangaard Brouer
2018-05-02 3:33 ` Toshiaki Makita
2018-05-02 5:56 ` Jesper Dangaard Brouer
2018-04-24 14:39 ` [PATCH RFC 7/9] veth: Add XDP TX and REDIRECT Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 8/9] veth: Avoid per-packet spinlock of XDP napi ring on dequeueing Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 9/9] veth: Avoid per-packet spinlock of XDP napi ring on enqueueing Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501095008.207c354f@brouer.com \
--to=brouer@redhat.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).