From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-master] iproute: Parse last nexthop in a
 multipath route
Date: Tue, 1 May 2018 19:37:05 -0700
Message-ID: <20180501193705.6044a561@xeon-e3>
References: <20180501131635.14981-1-idosch@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, dsahern@gmail.com, mlxsw@mellanox.com
To: Ido Schimmel <idosch@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f65.google.com ([74.125.83.65]:46474 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750766AbeEBChI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 1 May 2018 22:37:08 -0400
Received: by mail-pg0-f65.google.com with SMTP id z4-v6so9504722pgu.13
        for <netdev@vger.kernel.org>; Tue, 01 May 2018 19:37:08 -0700 (PDT)
In-Reply-To: <20180501131635.14981-1-idosch@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue,  1 May 2018 16:16:35 +0300
Ido Schimmel <idosch@mellanox.com> wrote:

> Continue parsing a multipath payload as long as another nexthop can fit
> in the payload.
> 
> # ip route add 192.0.2.0/24 nexthop dev dummy0 nexthop dev dummy1
> 
> Before:
> # ip route show 192.0.2.0/24
> 192.0.2.0/24
>         nexthop dev dummy0 weight 1
> 
> After:
> # ip route show 192.0.2.0/24
> 192.0.2.0/24
>         nexthop dev dummy0 weight 1
>         nexthop dev dummy1 weight 1
> 
> Fixes: f48e14880a0e ("iproute: refactor multipath print")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>


Applied, thanks.

There  really ought to be test cases for this.