From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jiong Wang <jiong.wang@netronome.com>
Cc: borkmann@iogearbox.net, ecree@solarflare.com,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information
Date: Tue, 1 May 2018 15:22:59 -0700 [thread overview]
Message-ID: <20180501222257.cogbkcsncrmg54p5@ast-mbp> (raw)
In-Reply-To: <1525127296-3573-1-git-send-email-jiong.wang@netronome.com>
On Mon, Apr 30, 2018 at 06:28:13PM -0400, Jiong Wang wrote:
>
> There is no functional change by this patch set.
> No bpf selftest regression found after this patch set.
I was about to apply them, but there is a regression:
[ 27.773899] ==================================================================
[ 27.774802] BUG: KASAN: slab-out-of-bounds in do_jit+0x5499/0x6020
[ 27.775559] Read of size 4 at addr ffff8801197fe7f4 by task test_verifier/344
[ 27.776412]
[ 27.776607] CPU: 3 PID: 344 Comm: test_verifier Not tainted 4.17.0-rc2-00451-geb43cb64a84a #943
[ 27.777644] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-1.el7.centos 04/01/2014
[ 27.778894] Call Trace:
[ 27.779217] dump_stack+0x5b/0x8b
[ 27.779675] ? do_jit+0x5499/0x6020
[ 27.780148] print_address_description+0x73/0x290
[ 27.780716] ? do_jit+0x5499/0x6020
[ 27.781152] kasan_report+0x22b/0x350
[ 27.781602] do_jit+0x5499/0x6020
[ 27.782020] ? __mod_node_page_state+0xa2/0xd0
[ 27.782557] ? jit_fill_hole+0x20/0x20
[ 27.783019] ? ___slab_alloc+0x3e7/0x4d0
[ 27.783498] ? kasan_unpoison_shadow+0x30/0x40
[ 27.784042] ? kasan_kmalloc+0xa0/0xd0
[ 27.784497] ? __kmalloc+0x109/0x200
[ 27.784931] ? bpf_int_jit_compile+0x7ac/0xab0
[ 27.785475] bpf_int_jit_compile+0x2b6/0xab0
[ 27.786001] ? do_jit+0x6020/0x6020
[ 27.786428] ? kasan_kmalloc+0xa0/0xd0
[ 27.786885] bpf_check+0x2c05/0x4c40
[ 27.787346] ? fixup_bpf_calls+0x1140/0x1140
[ 27.787865] ? kasan_unpoison_shadow+0x30/0x40
[ 27.788406] ? kasan_kmalloc+0xa0/0xd0
[ 27.788865] ? memset+0x1f/0x40
[ 27.789255] ? bpf_obj_name_cpy+0x2d/0x200
[ 27.789750] bpf_prog_load+0xb07/0xeb0
simply running test_verifier with JIT and kasan on.
next prev parent reply other threads:[~2018-05-01 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 22:28 [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 1/3] bpf: unify main prog and subprog Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 2/3] bpf: centre subprog information fields Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 3/3] bpf: add faked "ending" subprog Jiong Wang
2018-05-01 22:22 ` Alexei Starovoitov [this message]
2018-05-02 16:59 ` [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information Jiong Wang
2018-05-02 17:24 ` John Fastabend
2018-05-02 19:22 ` Jiong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501222257.cogbkcsncrmg54p5@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=ecree@solarflare.com \
--cc=jiong.wang@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox