From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: stranche@codeaurora.org, willemb@google.com,
netdev@vger.kernel.org, subashab@codeaurora.org
Subject: Re: [PATCH net-next] udp: Complement partial checksum for GSO packet
Date: Wed, 02 May 2018 11:00:00 -0400 (EDT) [thread overview]
Message-ID: <20180502.110000.670470404944831308.davem@davemloft.net> (raw)
In-Reply-To: <CAF=yD-K+15L9Ui227y04fhrQjCMa5WGyT+rydvM17BF94E8yLw@mail.gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Wed, 2 May 2018 11:25:43 +0200
> On Tue, May 1, 2018 at 12:06 PM, Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
>> On Tue, May 1, 2018 at 2:01 AM, Sean Tranchetti <stranche@codeaurora.org> wrote:
>>> Using the udp_v4_check() function to calculate the pseudo header
>>> for the newly segmented UDP packets results in assigning the complement
>>> of the value to the UDP header checksum field.
>>>
>>> Always undo the complement the partial checksum value in order to
>>> match the case where GSO is not used on the UDP transmit path.
>>>
>>> Fixes: ee80d1ebe5ba ("udp: add udp gso")
>>> Signed-off-by: Sean Tranchetti <stranche@codeaurora.org>
>>> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
>
> Acked-by: Willem de Bruijn <willemb@google.com>
>
> Thanks Sean.
Applied, thanks everyone.
prev parent reply other threads:[~2018-05-02 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 0:01 [PATCH net-next] udp: Complement partial checksum for GSO packet Sean Tranchetti
2018-05-01 10:06 ` Willem de Bruijn
2018-05-02 9:25 ` Willem de Bruijn
2018-05-02 15:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502.110000.670470404944831308.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
--cc=subashab@codeaurora.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).