From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] udp: Complement partial checksum for GSO packet Date: Wed, 02 May 2018 11:00:00 -0400 (EDT) Message-ID: <20180502.110000.670470404944831308.davem@davemloft.net> References: <1525132862-7672-1-git-send-email-stranche@codeaurora.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: stranche@codeaurora.org, willemb@google.com, netdev@vger.kernel.org, subashab@codeaurora.org To: willemdebruijn.kernel@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:60974 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbeEBPAC (ORCPT ); Wed, 2 May 2018 11:00:02 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Willem de Bruijn Date: Wed, 2 May 2018 11:25:43 +0200 > On Tue, May 1, 2018 at 12:06 PM, Willem de Bruijn > wrote: >> On Tue, May 1, 2018 at 2:01 AM, Sean Tranchetti wrote: >>> Using the udp_v4_check() function to calculate the pseudo header >>> for the newly segmented UDP packets results in assigning the complement >>> of the value to the UDP header checksum field. >>> >>> Always undo the complement the partial checksum value in order to >>> match the case where GSO is not used on the UDP transmit path. >>> >>> Fixes: ee80d1ebe5ba ("udp: add udp gso") >>> Signed-off-by: Sean Tranchetti >>> Signed-off-by: Subash Abhinov Kasiviswanathan > > Acked-by: Willem de Bruijn > > Thanks Sean. Applied, thanks everyone.