From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d Date: Wed, 02 May 2018 11:16:45 -0400 (EDT) Message-ID: <20180502.111645.2168255311623555739.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33028 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbeEBPQq (ORCPT ); Wed, 2 May 2018 11:16:46 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Wed, 2 May 2018 13:39:46 +0800 > When processing a duplicate cookie-echo chunk, for case 'D', sctp will > not process the param from this chunk. It means old asoc has nothing > to be updated, and the new temp asoc doesn't have the complete info. > > So there's no reason to use the new asoc when creating the cookie-ack > chunk. Otherwise, like when auth is enabled for cookie-ack, the chunk > can not be set with auth, and it will definitely be dropped by peer. > > This issue is there since very beginning, and we fix it by using the > old asoc instead. > > Signed-off-by: Xin Long Applied and queued up for -stable.