Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sunlw.fnst@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] change the comment of ip6gre_tnl_addr_conflict
Date: Wed, 02 May 2018 13:19:37 -0400 (EDT)	[thread overview]
Message-ID: <20180502.131937.79273881798358525.davem@davemloft.net> (raw)
In-Reply-To: <20180502090608.13612-1-sunlw.fnst@cn.fujitsu.com>

From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Date: Wed, 2 May 2018 17:06:08 +0800

> The comment of ip6gre_tnl_addr_conflict() is wrong. which use
> ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict.
> 
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>

Please format your Subject line properly.

If should start with "[PATCH X] " where "X" is the name of the
networking GIT tree your patch is against.

Then there should be a subsystem prefix, followed by a colon ":" and a
space character.  In this case, "ipv6: " would be an appropriate
subject prefix.

Then, please make your Subject sentence more clear.

Be more precise with what you are doing.  You are correcting the
function name in a comment, so say something that expresses that.

Thank you.

      reply	other threads:[~2018-05-02 17:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  9:06 [PATCH] change the comment of ip6gre_tnl_addr_conflict Sun Lianwen
2018-05-02 17:19 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502.131937.79273881798358525.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sunlw.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox