[PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c

[PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c

[Bo YU]

Optimization of command output: `cat /proc/net/netlink`

After the patch, we will get:

https://clbin.com/lnu4L

Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
  net/netlink/af_netlink.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 55342c4d5cec..2e2dd88fc79f 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file *seq, void *v)
  {
  	if (v == SEQ_START_TOKEN) {
  		seq_puts(seq,
-			 "sk       Eth Pid    Groups   "
-			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
+			 "sk               Eth Pid        Groups   "
+			 "Rmem     Wmem     Dump  Locks    Drops    Inode\n");
  	} else {
  		struct sock *s = v;
  		struct netlink_sock *nlk = nlk_sk(s);

-		seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d %-8lu\n",
+		seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n",
  			   s,
  			   s->sk_protocol,
  			   nlk->portid,

Re: [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c

[David Miller]

From: Bo YU <tsu.yubo@gmail.com>
Date: Wed, 2 May 2018 05:54:24 -0400

> Optimization of command output: `cat /proc/net/netlink`
> 
> After the patch, we will get:
> 
> https://clbin.com/lnu4L
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
>  net/netlink/af_netlink.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 55342c4d5cec..2e2dd88fc79f 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file
> *seq, void *v)
>  {
>  	if (v == SEQ_START_TOKEN) {
>  		seq_puts(seq,
> -			 "sk       Eth Pid    Groups   "
> -			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
> +			 "sk               Eth Pid        Groups   "
> + "Rmem Wmem Dump Locks Drops Inode\n");

Please do not break the indentation of the code like this.

I wish to unfortunately say, that generally speaking, your patch
submissions are not of the best quality, and take up a lot of reviewer
time and resources as a result.

If you do not improve the quality of your submissions, I am giving
you a kind warning that the amount of care and review your patches
will receive will become lower.  Your submissions might even get to
the point wheere they are effectively ignored.

So please put more care into your work.

Thank you.

Re: [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c

[YU Bo]

Hi,
On Wed, May 02, 2018 at 10:19:43AM -0400, David Miller wrote:
>From: Bo YU <tsu.yubo@gmail.com>
>Date: Wed, 2 May 2018 05:54:24 -0400
>
>> Optimization of command output: `cat /proc/net/netlink`
>>
>> After the patch, we will get:
>>
>> https://clbin.com/lnu4L
>>
>> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
>> ---
>>  net/netlink/af_netlink.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
>> index 55342c4d5cec..2e2dd88fc79f 100644
>> --- a/net/netlink/af_netlink.c
>> +++ b/net/netlink/af_netlink.c
>> @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file
>> *seq, void *v)
>>  {
>>  	if (v == SEQ_START_TOKEN) {
>>  		seq_puts(seq,
>> -			 "sk       Eth Pid    Groups   "
>> -			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
>> +			 "sk               Eth Pid        Groups   "
>> + "Rmem Wmem Dump Locks Drops Inode\n");
>
>Please do not break the indentation of the code like this.
Sorry, i am shame to do like it.There are something happened in my different
version vim.Because checkpatch tell me only
"WARNING: quoted string split across lines"

Thank you, i will fix it.

>
>I wish to unfortunately say, that generally speaking, your patch
>submissions are not of the best quality, and take up a lot of reviewer
>time and resources as a result.
>
>If you do not improve the quality of your submissions, I am giving
>you a kind warning that the amount of care and review your patches
>will receive will become lower.  Your submissions might even get to
>the point wheere they are effectively ignored.
>
>So please put more care into your work.
>
>Thank you.