public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Sirio Balmelli <sirio@b-ad.ch>
To: daniel@iogearbox.net
Cc: netdev@vger.kernel.org
Subject: [PATCH v3 0/3] selftests/bpf
Date: Wed, 2 May 2018 13:04:50 +0200	[thread overview]
Message-ID: <20180502110448.w2t4dy4i4b2rwopn@vm4> (raw)

Review of v2 patch appreciated.
Trying a saner approach for includes handling,
thank you daniel@iogearbox.net for steering me in the right direction.

Please note I did run into some missing headers that were nowhere
in '$(KERNEL)/tools'  at all, but present in '$(KERNEL)/usr/include'.
I'm assuming these selftests already build for almost everyone else since they
probably have a sane '/usr/include' ecosystem, which this particular
Ubuntu system does not.

Rather than copy individual headers into '$(KERNEL)/tools/include' however,
I decided to simply point at '$(KERNEL)/usr/include'.

The idea is to rely less on the headers outside the kernel tree,
but also avoid adding maintenance burden by duplicating headers into
'tools'.

Let me know what you think.

Sirio Balmelli (3):
  selftests/bpf: add architecture-agnostic headers in tools/include
  selftests/bpf: Makefile: add include path to $(KERNEL)/usr/include
  selftests/bpf: ignore build products

 tools/bpf/bpftool/.gitignore           |  3 +++
 tools/include/uapi/asm/bitsperlong.h   | 18 ++++++++++++++++++
 tools/include/uapi/asm/errno.h         | 17 +++++++++++++++++
 tools/testing/selftests/bpf/.gitignore |  1 +
 tools/testing/selftests/bpf/Makefile   |  5 ++++-
 5 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 tools/bpf/bpftool/.gitignore
 create mode 100644 tools/include/uapi/asm/bitsperlong.h
 create mode 100644 tools/include/uapi/asm/errno.h

-- 
2.7.4

                 reply	other threads:[~2018-05-02 11:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502110448.w2t4dy4i4b2rwopn@vm4 \
    --to=sirio@b-ad.ch \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox