From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v9 2/4] net: Introduce generic failover module Date: Wed, 2 May 2018 18:15:42 +0200 Message-ID: <20180502161542.GI19250@nanopsycho> References: <1524848820-42258-1-git-send-email-sridhar.samudrala@intel.com> <1524848820-42258-3-git-send-email-sridhar.samudrala@intel.com> <20180428090601.GL5632@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mst@redhat.com, stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com To: Sridhar Samudrala Return-path: Received: from mail-wr0-f180.google.com ([209.85.128.180]:35174 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbeEBQPo (ORCPT ); Wed, 2 May 2018 12:15:44 -0400 Received: by mail-wr0-f180.google.com with SMTP id i14-v6so11477168wre.2 for ; Wed, 02 May 2018 09:15:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180428090601.GL5632@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: Sat, Apr 28, 2018 at 11:06:01AM CEST, jiri@resnulli.us wrote: >Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudrala@intel.com wrote: [...] >>+ >>+ err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, >>+ failover_dev); >>+ if (err) { >>+ netdev_err(slave_dev, "can not register failover rx handler (err = %d)\n", >>+ err); >>+ goto err_handler_register; >>+ } >>+ >>+ err = netdev_upper_dev_link(slave_dev, failover_dev, NULL); > >Please use netdev_master_upper_dev_link(). Don't forget to fillup struct netdev_lag_upper_info - NETDEV_LAG_TX_TYPE_ACTIVEBACKUP Also, please call netdev_lower_state_changed() when the active slave device changes from primary->backup of backup->primary and whenever link state of a slave changes [...]