From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops Date: Wed, 2 May 2018 22:04:01 +0300 Message-ID: <20180502190401.GA470@splinter> References: <20180109144028.30133-1-idosch@mellanox.com> <20180109144028.30133-2-idosch@mellanox.com> <5550c628-5014-427b-60c9-71cf80462723@gmail.com> <20180502172106.GA12986@splinter> <20180502175244.GA14587@splinter> <20180502185310.GA31998@splinter> <017f58ee-8655-60d1-19aa-a6276c639065@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Dumazet , Thomas.Winter@alliedtelesis.co.nz, davem@davemloft.net, Ido Schimmel , netdev@vger.kernel.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, pch@ordbogen.com, jkbs@redhat.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: David Ahern Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40229 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbeEBTEG (ORCPT ); Wed, 2 May 2018 15:04:06 -0400 Content-Disposition: inline In-Reply-To: <017f58ee-8655-60d1-19aa-a6276c639065@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, May 02, 2018 at 12:58:56PM -0600, David Ahern wrote: > On 5/2/18 12:53 PM, Ido Schimmel wrote: > > > > So this fixes the issue for me. To reproduce: > > > > # ip -6 address add 2001:db8::1/64 dev dummy0 > > # ip -6 address add 2001:db8::1/64 dev dummy1 > > > > This reproduces the issue because due to above commit both local routes > > are considered siblings... :/ > > > > local 2001:db8::1 proto kernel metric 0 > > nexthop dev dummy0 weight 1 > > nexthop dev dummy1 weight 1 pref medium > > > > I think it's best to revert the patch and have Thomas submit a fixed > > version to net-next. I was actually surprised to see it applied to net. > > ugly side effect of the way ecmp routes are managed in IPv6. I think > revert is the best option for now. OK. I'll send a patch.