From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: borkmann@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org
Subject: Re: [bpf PATCH v2 0/3] sockmap error path fixes
Date: Wed, 2 May 2018 15:34:03 -0700 [thread overview]
Message-ID: <20180502223401.2nl7oivuv4qbfznv@ast-mbp> (raw)
In-Reply-To: <20180502204748.12776.80509.stgit@john-Precision-Tower-5810>
On Wed, May 02, 2018 at 01:50:14PM -0700, John Fastabend wrote:
> When I added the test_sockmap to selftests I mistakenly changed the
> test logic a bit. The result of this was on redirect cases we ended up
> choosing the wrong sock from the BPF program and ended up sending to a
> socket that had no receive handler. The result was the actual receive
> handler, running on a different socket, is timing out and closing the
> socket. This results in errors (-EPIPE to be specific) on the sending
> side. Typically happening if the sender does not complete the send
> before the receive side times out. So depending on timing and the size
> of the send we may get errors. This exposed some bugs in the sockmap
> error path handling.
>
> This series fixes the errors. The primary issue is we did not do proper
> memory accounting in these cases which resulted in missing a
> sk_mem_uncharge(). This happened in the redirect path and in one case
> on the normal send path. See the three patches for the details.
>
> The other take-away from this is we need to fix the test_sockmap and
> also add more negative test cases. That will happen in bpf-next.
>
> Finally, I tested this using the existing test_sockmap program, the
> older sockmap sample test script, and a few real use cases with
> Cilium. All of these seem to be in working correctly.
>
> v2: fix compiler warning, drop iterator variable 'i' that is no longer
> used in patch 3.
Applied, Thanks.
prev parent reply other threads:[~2018-05-02 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 20:50 [bpf PATCH v2 0/3] sockmap error path fixes John Fastabend
2018-05-02 20:50 ` [bpf PATCH v2 1/3] bpf: sockmap, fix scatterlist update on error path in send with apply John Fastabend
2018-05-02 20:50 ` [bpf PATCH v2 2/3] bpf: sockmap, zero sg_size on error when buffer is released John Fastabend
2018-05-02 20:50 ` [bpf PATCH v2 3/3] bpf: sockmap, fix error handling in redirect failures John Fastabend
2018-05-02 22:34 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502223401.2nl7oivuv4qbfznv@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox