From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v7 1/7] sched: Add Common Applications Kept
 Enhanced (cake) qdisc
Date: Thu, 03 May 2018 11:24:02 -0400 (EDT)
Message-ID: <20180503.112402.774278226377528271.davem@davemloft.net>
References: <152527385803.14936.8396262019181995139.stgit@alrua-kau>
        <152527386316.14936.5409621935637217368.stgit@alrua-kau>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: toke@toke.dk
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48334 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751050AbeECPYE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 3 May 2018 11:24:04 -0400
In-Reply-To: <152527386316.14936.5409621935637217368.stgit@alrua-kau>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Wed, 02 May 2018 17:11:03 +0200

> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
> new file mode 100644
> index 000000000000..18bc147f12bc
> --- /dev/null
> +++ b/net/sched/sch_cake.c
> +static inline cobalt_time_t cobalt_get_time(void)
> +{
> +	return ktime_get_ns();
> +}

Please do not use inline in foo.c files, let the compiler decide.

> +static inline u32
> +cake_hash(struct cake_tin_data *q, const struct sk_buff *skb, int flow_mode)
> +{

Especially for this monster!  Yikes!