From: David Miller <davem@davemloft.net>
To: petrm@mellanox.com
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH net-next mlxsw 0/3] selftests: forwarding: Updates to sysctl handling
Date: Thu, 03 May 2018 13:37:34 -0400 (EDT) [thread overview]
Message-ID: <20180503.133734.1839164892433201492.davem@davemloft.net> (raw)
In-Reply-To: <cover.1525343276.git.petrm@mellanox.com>
From: Petr Machata <petrm@mellanox.com>
Date: Thu, 03 May 2018 12:36:52 +0200
> Some selftests need to adjust sysctl settings. In order to be neutral to
> the system that the test is run on, it is a good practice to change back
> to the original setting after the test ends. That involves some
> boilerplate that can be abstracted away.
>
> In patch #1, introduce two functions, sysctl_set() and sysctl_restore().
> The former stores the current value of a given setting, and sets a new
> value. The latter restores the setting to the previously-stored value.
>
> In patch #2, use these wrappers in a number of tests.
>
> Additionally in patch #3, fix a problem in mirror_gre_nh.sh, which
> neglected to set a sysctl that's crucial for the test to work.
Luckily that errant 'mlxsw' hides inside of [] so git will get rid of
it :-)
Series applied, thanks.
prev parent reply other threads:[~2018-05-03 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:36 [PATCH net-next mlxsw 0/3] selftests: forwarding: Updates to sysctl handling Petr Machata
2018-05-03 10:36 ` [PATCH net-next mlxsw 1/3] selftests: forwarding: lib: Add sysctl_set(), sysctl_restore() Petr Machata
2018-05-03 10:37 ` [PATCH net-next mlxsw 2/3] selftests: forwarding: Use " Petr Machata
2018-05-03 10:37 ` [PATCH net-next mlxsw 3/3] selftests: forwarding: mirror_gre_nh: Unset RP filter Petr Machata
2018-05-03 17:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503.133734.1839164892433201492.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).