From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: bridge: avoid duplicate notification on up/down/change netdev events Date: Thu, 03 May 2018 13:41:19 -0400 (EDT) Message-ID: <20180503.134119.613881858170428292.davem@davemloft.net> References: <20180503104724.17799-1-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, stephen@networkplumber.org, bridge@lists.linux-foundation.org To: nikolay@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50224 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbeECRlV (ORCPT ); Thu, 3 May 2018 13:41:21 -0400 In-Reply-To: <20180503104724.17799-1-nikolay@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nikolay Aleksandrov Date: Thu, 3 May 2018 13:47:24 +0300 > While handling netdevice events, br_device_event() sometimes uses > br_stp_(disable|enable)_port which unconditionally send a notification, > but then a second notification for the same event is sent at the end of > the br_device_event() function. To avoid sending duplicate notifications > in such cases, check if one has already been sent (i.e. > br_stp_enable/disable_port have been called). > The patch is based on a change by Satish Ashok. > > Signed-off-by: Nikolay Aleksandrov > --- > We've been running with a similar patch for over an year, it's been > thoroughly tested. Sending for net-next since it's an improvement and > not really a bug fix. Looks good, applied, thanks!