From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: borkmann@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 0/4] Hash support for sock
Date: Thu, 03 May 2018 14:31:23 -0400 (EDT) [thread overview]
Message-ID: <20180503.143123.1034749788277999334.davem@davemloft.net> (raw)
In-Reply-To: <1525372108-8690-1-git-send-email-john.fastabend@gmail.com>
From: John Fastabend <john.fastabend@gmail.com>
Date: Thu, 3 May 2018 11:28:24 -0700
> In the original sockmap implementation we got away with using an
> array similar to devmap. However, unlike devmap where an ifindex
> has a nice 1:1 function into the map we have found some use cases
> with sockets that need to be referenced using longer keys.
>
> This series adds support for a sockhash map reusing as much of
> the sockmap code as possible. I made the decision to add sockhash
> specific helpers vs trying to generalize the existing helpers
> because (a) they have sockmap in the name and (b) the keys are
> different types. I prefer to be explicit here rather than play
> type games or do something else tricky.
>
> To test this we duplicate all the sockmap testing except swap out
> the sockmap with a sockhash.
>
> v2: fix file stats and add v2 tag
> v3: move tool updates into test patch, move bpftool updates into
> its own patch, and fixup the test patch stats to catch the
> renamed file and provide only diffs +/- on that.
> v4: Add documentation to UAPI bpf.h
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2018-05-03 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:28 [PATCH bpf-next v4 0/4] Hash support for sock John Fastabend
2018-05-03 18:28 ` [PATCH bpf-next v4 1/4] bpf: sockmap, refactor sockmap routines to work with hashmap John Fastabend
2018-05-03 18:28 ` [PATCH bpf-next v4 2/4] bpf: sockmap, add hash map support John Fastabend
2018-05-03 18:28 ` [PATCH bpf-next v4 3/4] bpf: selftest additions for SOCKHASH John Fastabend
2018-05-04 10:11 ` Quentin Monnet
2018-05-03 18:28 ` [PATCH bpf-next v4 4/4] bpf: bpftool, support for sockhash John Fastabend
2018-05-03 18:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503.143123.1034749788277999334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).