From mboxrd@z Thu Jan 1 00:00:00 1970 From: YU Bo Subject: Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c Date: Thu, 3 May 2018 18:57:35 +0800 Message-ID: <20180503105734.7yp5fg55v7cx34o2@debian.debian> References: <20180503090901.35bxgzs2tjsl7bqr@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, yuzibode@126.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Julia Lawall Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:40589 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbeECK5k (ORCPT ); Thu, 3 May 2018 06:57:40 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hello, On Thu, May 03, 2018 at 11:44:33AM +0200, Julia Lawall wrote: > > >On Thu, 3 May 2018, YU Bo wrote: > >> Before the patch, the command `cat /proc/net/netlink` will output like: >> >> https://clbin.com/BojZv >> >> After the patch: >> >> https://clbin.com/lnu4L >> >> The optimization will make convenience for using `cat /proc/net/netlink` >> But,The checkpatch will give a warning: >> >> WARNING: quoted string split across lines > >The interest of the checkpatch warning is that someone may want to grep >for something that has actually been split over two lines. If this is not >an issue in your case and if there are good reasons for splitting the >string, then you can ignore checkpatch. Yes, the warning will be generated in original af_netlink.c and i dom't think to split it is better. Thank you! > >julia > >> >> Signed-off-by: Bo YU >> --- >> Changes in v2: >> Do not break the indentation of the code line >> --- >> net/netlink/af_netlink.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c >> index 55342c4d5cec..2e2dd88fc79f 100644 >> --- a/net/netlink/af_netlink.c >> +++ b/net/netlink/af_netlink.c >> @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file *seq, void >> *v) >> { >> if (v == SEQ_START_TOKEN) { >> seq_puts(seq, >> - "sk Eth Pid Groups " >> - "Rmem Wmem Dump Locks Drops >> Inode\n"); >> + "sk Eth Pid Groups " >> + "Rmem Wmem Dump Locks Drops Inode\n"); >> } else { >> struct sock *s = v; >> struct netlink_sock *nlk = nlk_sk(s); >> >> - seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d >> %-8lu\n", >> + seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d >> %-8lu\n", >> s, >> s->sk_protocol, >> nlk->portid, >> -- >> 2.11.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >>