From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Boris Pismenny <borisp@mellanox.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [bug report] net/mlx5e: TLS, Add Innova TLS TX offload data path
Date: Thu, 3 May 2018 15:07:57 +0300 [thread overview]
Message-ID: <20180503120757.GA1641@mtr-leonro.local> (raw)
In-Reply-To: <20180503112300.GA6309@mwanda>
[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]
+ Saeed, Boris and netdev
On Thu, May 03, 2018 at 02:23:00PM +0300, Dan Carpenter wrote:
> Hello Ilya Lesokhin,
>
> The patch bf23974104fa: "net/mlx5e: TLS, Add Innova TLS TX offload
> data path" from Apr 30, 2018, leads to the following static checker
> warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c:63 mlx5e_tls_add_metadata()
> warn: struct type mismatch 'ethhdr vs mlx5e_tls_metadata'
>
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c
> 55 static int mlx5e_tls_add_metadata(struct sk_buff *skb, __be32 swid)
> 56 {
> 57 struct mlx5e_tls_metadata *pet;
> 58 struct ethhdr *eth;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 59
> 60 if (skb_cow_head(skb, sizeof(struct mlx5e_tls_metadata)))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 61 return -ENOMEM;
> 62
> 63 eth = (struct ethhdr *)skb_push(skb, sizeof(struct mlx5e_tls_metadata));
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This feels like it should be sizeof(*eth) + sizeof(*pet)?
>
> 64 skb->mac_header -= sizeof(struct mlx5e_tls_metadata);
> 65 pet = (struct mlx5e_tls_metadata *)(eth + 1);
> 66
> 67 memmove(skb->data, skb->data + sizeof(struct mlx5e_tls_metadata),
> 68 2 * ETH_ALEN);
> 69
> 70 eth->h_proto = cpu_to_be16(MLX5E_METADATA_ETHER_TYPE);
> 71 pet->syndrome_swid = htonl(SYNDROME_OFFLOAD_REQUIRED << 24) | swid;
> 72
> 73 return 0;
> 74 }
>
> regards,
> dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next parent reply other threads:[~2018-05-03 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180503112300.GA6309@mwanda>
2018-05-03 12:07 ` Leon Romanovsky [this message]
2018-05-03 16:04 ` [bug report] net/mlx5e: TLS, Add Innova TLS TX offload data path Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503120757.GA1641@mtr-leonro.local \
--to=leon@kernel.org \
--cc=borisp@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).