From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES
 support
Date: Thu, 3 May 2018 15:15:15 +0200
Message-ID: <20180503131515.GB17027@lunn.ch>
References: <20180503130648.23225-1-marek.behun@nic.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>
To: Marek =?iso-8859-1?Q?Beh=FAn?= <marek.behun@nic.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:48141 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750970AbeECNPR (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 3 May 2018 09:15:17 -0400
Content-Disposition: inline
In-Reply-To: <20180503130648.23225-1-marek.behun@nic.cz>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote:
> The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane,
> which can be configured the same way as the SERDES lane on 88E6390.
> 
> Signed-off-by: Marek Behun <marek.behun@nic.cz>

> +int mv88e6341_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
> +{
> +	int err;
> +	u8 cmode;
> +
> +	if (port != 5)
> +		return 0;
> +
> +	err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
> +	if (err)
> +		return err;
> +
> +	if ((cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
> +	     (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII) ||
> +	     (cmode == MV88E6XXX_PORT_STS_CMODE_2500BASEX))
> +		return mv88e6390_serdes_sgmii(chip, 0x15, on);

Hi Marek

Please add a #define for this 0x15.

Otherwise, this looks good.

	   Andrew