From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter
 using Flexible RX Parser
Date: Thu, 3 May 2018 17:57:44 -0700
Message-ID: <20180503175744.6dc32fb9@cakuba.netronome.com>
References: <9f57f98ef35360619001882fdcf0d7ef0558863f.1525351447.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Vitor Soares <Vitor.Soares@synopsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3.wp.pl ([212.77.101.9]:42446 "EHLO mx3.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751126AbeEDA5x (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 3 May 2018 20:57:53 -0400
In-Reply-To: <9f57f98ef35360619001882fdcf0d7ef0558863f.1525351447.git.joabreu@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu,  3 May 2018 13:45:30 +0100, Jose Abreu wrote:
> +	case TC_SETUP_CLSU32:
> +		if (!(priv->dev->hw_features & NETIF_F_HW_TC))
> +			ret = -EOPNOTSUPP;
> +		else
> +			ret = stmmac_tc_setup_cls_u32(priv, priv, type_data);
> +		break;

Please just use tc_cls_can_offload_and_chain0().  The extack message it
sets is useful for debugging and you don't support chains other than 0
either.