From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] liquidio: support use of ethtool to set link
 speed of CN23XX-225 cards
Date: Fri, 04 May 2018 13:00:22 -0400 (EDT)
Message-ID: <20180504.130022.456100476632220937.davem@davemloft.net>
References: <20180504022325.GA1332@felix-thinkpad.cavium.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
        derek.chickles@cavium.com, satananda.burla@cavium.com,
        weilin.chang@cavium.com
To: felix.manlunas@cavium.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35620 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751425AbeEDRA0 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 4 May 2018 13:00:26 -0400
In-Reply-To: <20180504022325.GA1332@felix-thinkpad.cavium.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Thu, 3 May 2018 19:23:25 -0700

> +static int lio_set_link_ksettings(struct net_device *netdev,
> +				  const struct ethtool_link_ksettings *ecmd)
> +{
> +	struct lio *lio = GET_LIO(netdev);
> +	struct octeon_device *oct = lio->oct_dev;
> +	struct oct_link_info *linfo;
> +	const int speed = ecmd->base.speed;
> +	u32 is25G = 0;

Please order local variable declarations from longest to shortest line,
as was properly done in the rest of this patch.

Thank you.