From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 2/4] net: 3com: 3c59x: Move boomerang/vortex conditional into function Date: Fri, 4 May 2018 17:22:28 +0200 Message-ID: <20180504152228.o24gdwcf2oft52u4@linutronix.de> References: <20180504151749.6966-1-bigeasy@linutronix.de> <20180504151749.6966-3-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, "David S. Miller" , tglx@linutronix.de, Anna-Maria Gleixner To: Steffen Klassert Return-path: Received: from Galois.linutronix.de ([146.0.238.70]:41184 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbeEDPWb (ORCPT ); Fri, 4 May 2018 11:22:31 -0400 Content-Disposition: inline In-Reply-To: <20180504151749.6966-3-bigeasy@linutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On 2018-05-04 17:17:47 [+0200], To netdev@vger.kernel.org wrote: > From: Anna-Maria Gleixner > > If vp->full_bus_master_tx is set, vp->full_bus_master_rx is set as well > (see vortex_probe1()). Therefore the conditionals for the decision if > boomerang or vortex ISR is executed have the same result. Instead of > repeating the explicit conditional execution of the boomerang/vortex ISR, > move it into an own function. > > No functional change. > > Cc: Steffen Klassert Steffen, this email address is still listed in the MAINTAINERS file for the driver and rejects emails. Sebastian