From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: Re: [PATCH net-next] net: core: rework skb_probe_transport_header() Date: Sat, 5 May 2018 05:35:21 +0800 Message-ID: <201805050515.eZzgSCKx%fengguang.wu@intel.com> References: <7cbdf466f4a1bf44ddbb948428dc7bb0dad091a7.1525340013.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jason Wang To: Paolo Abeni Return-path: Received: from mga05.intel.com ([192.55.52.43]:29694 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbeEDVfa (ORCPT ); Fri, 4 May 2018 17:35:30 -0400 Content-Disposition: inline In-Reply-To: <7cbdf466f4a1bf44ddbb948428dc7bb0dad091a7.1525340013.git.pabeni@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Paolo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-core-rework-skb_probe_transport_header/20180504-041345 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> include/linux/skbuff.h:2360:32: sparse: Using plain integer as NULL pointer drivers/net/tun.c:2088:40: sparse: expression using sizeof(void) drivers/net/tun.c:2221:15: sparse: expression using sizeof(void) drivers/net/tun.c:2221:15: sparse: expression using sizeof(void) drivers/net/tun.c:2846:36: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct tun_prog [noderef] **prog_p @@ got noderef] **prog_p @@ drivers/net/tun.c:2846:36: expected struct tun_prog [noderef] **prog_p drivers/net/tun.c:2846:36: got struct tun_prog **prog_p drivers/net/tun.c:3142:42: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct tun_prog **prog_p @@ got struct tun_prog [struct tun_prog **prog_p @@ drivers/net/tun.c:3142:42: expected struct tun_prog **prog_p drivers/net/tun.c:3142:42: got struct tun_prog [noderef] ** drivers/net/tun.c:3146:42: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct tun_prog **prog_p @@ got struct tun_prog [struct tun_prog **prog_p @@ drivers/net/tun.c:3146:42: expected struct tun_prog **prog_p drivers/net/tun.c:3146:42: got struct tun_prog [noderef] ** -- >> include/linux/skbuff.h:2360:32: sparse: Using plain integer as NULL pointer drivers/net/tap.c:879:15: sparse: expression using sizeof(void) drivers/net/tap.c:879:15: sparse: expression using sizeof(void) -- drivers/net/xen-netback/netback.c:175:21: sparse: expression using sizeof(void) drivers/net/xen-netback/netback.c:182:35: sparse: expression using sizeof(void) drivers/net/xen-netback/netback.c:182:35: sparse: expression using sizeof(void) >> include/linux/skbuff.h:2360:32: sparse: Using plain integer as NULL pointer drivers/net/xen-netback/netback.c:1632:37: sparse: expression using sizeof(void) vim +2360 include/linux/skbuff.h 2349 2350 static inline void skb_probe_transport_header(struct sk_buff *skb, 2351 const int offset_hint) 2352 { 2353 struct flow_keys_basic keys; 2354 2355 if (skb_transport_header_was_set(skb)) 2356 return; 2357 2358 memset(&keys, 0, sizeof(keys)); 2359 if (__skb_flow_dissect(skb, &flow_keys_buf_dissector, &keys, > 2360 0, 0, 0, 0, 0)) 2361 skb_set_transport_header(skb, keys.control.thoff); 2362 else 2363 skb_set_transport_header(skb, offset_hint); 2364 } 2365 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation