From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Tomt Subject: [PATCH net] net/tls: Fix connection stall on partial tls record Date: Mon, 7 May 2018 04:24:39 +0200 Message-ID: <20180507022439.265020-1-andre@tomt.net> Cc: Andre Tomt To: "David S . Miller" , netdev@vger.kernel.org, borisp@mellanox.com, Aviad Yehezkel , Dave Watson Return-path: Received: from mail1.ugh.no ([178.79.162.34]:46840 "EHLO mail1.ugh.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbeEGCZD (ORCPT ); Sun, 6 May 2018 22:25:03 -0400 Sender: netdev-owner@vger.kernel.org List-ID: In the case of writing a partial tls record we forgot to clear the ctx->in_tcp_sendpages flag, causing some connections to stall. Fixes: c212d2c7fc47 ("net/tls: Don't recursively call push_record during tls_write_space callbacks") Signed-off-by: Andre Tomt --- net/tls/tls_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index cc03e00785c7..a02ebdfa0675 100644 --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -135,6 +135,7 @@ int tls_push_sg(struct sock *sk, offset -= sg->offset; ctx->partially_sent_offset = offset; ctx->partially_sent_record = (void *)sg; + ctx->in_tcp_sendpages = false; return ret; } -- 2.17.0