From: Stephen Hemminger <stephen@networkplumber.org>
To: GhantaKrishnamurthy MohanKrishna
<mohan.krishna.ghanta.krishnamurthy@ericsson.com>
Cc: <tipc-discussion@lists.sourceforge.net>, <jon.maloy@ericsson.com>,
<maloy@donjonn.com>, <ying.xue@windriver.com>,
<netdev@vger.kernel.org>, <davem@davemloft.net>,
<dsahern@gmail.com>
Subject: Re: [iproute2-next 1/1] tipc: Add support to set and get MTU for UDP bearer
Date: Mon, 7 May 2018 07:46:26 -0700 [thread overview]
Message-ID: <20180507074626.67d0c07a@xeon-e3> (raw)
In-Reply-To: <1525691673-22966-1-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com>
On Mon, 7 May 2018 13:14:33 +0200
GhantaKrishnamurthy MohanKrishna <mohan.krishna.ghanta.krishnamurthy@ericsson.com> wrote:
> + struct opt *opts)
> +{
> + struct opt *opt;
> +
> + if (!(opt = get_opt(opts, "media"))) {
You don't need to have assignment in conditional context in this case.
Please split the assignment and the if.
prev parent reply other threads:[~2018-05-07 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 11:14 [iproute2-next 1/1] tipc: Add support to set and get MTU for UDP bearer GhantaKrishnamurthy MohanKrishna
2018-05-07 14:46 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507074626.67d0c07a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).