From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2-next  1/1] tipc: Add support to set and get MTU for
 UDP bearer
Date: Mon, 7 May 2018 07:46:26 -0700
Message-ID: <20180507074626.67d0c07a@xeon-e3>
References: <1525691673-22966-1-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <tipc-discussion@lists.sourceforge.net>, <jon.maloy@ericsson.com>,
        <maloy@donjonn.com>, <ying.xue@windriver.com>,
        <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <dsahern@gmail.com>
To: GhantaKrishnamurthy MohanKrishna
        <mohan.krishna.ghanta.krishnamurthy@ericsson.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f44.google.com ([209.85.214.44]:37515 "EHLO
        mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752185AbeEGOq3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 7 May 2018 10:46:29 -0400
Received: by mail-it0-f44.google.com with SMTP id 70-v6so11942304ity.2
        for <netdev@vger.kernel.org>; Mon, 07 May 2018 07:46:29 -0700 (PDT)
In-Reply-To: <1525691673-22966-1-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 7 May 2018 13:14:33 +0200
GhantaKrishnamurthy MohanKrishna         <mohan.krishna.ghanta.krishnamurthy@ericsson.com> wrote:

> +				struct opt *opts)
> +{
> +	struct opt *opt;
> +
> +	if (!(opt = get_opt(opts, "media"))) {

You don't need to have assignment in conditional context in this case.
Please split the assignment and the if.