From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [bpf-next v2 8/9] bpf: Provide helper to do forwarding lookups in kernel FIB table Date: Mon, 7 May 2018 15:35:52 +0200 Message-ID: <20180507153552.5063a4b2@redhat.com> References: <20180504025432.23451-1-dsahern@gmail.com> <20180504025432.23451-9-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, borkmann@iogearbox.net, ast@kernel.org, davem@davemloft.net, shm@cumulusnetworks.com, roopa@cumulusnetworks.com, toke@toke.dk, john.fastabend@gmail.com, brouer@redhat.com To: David Ahern Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750732AbeEGNgE (ORCPT ); Mon, 7 May 2018 09:36:04 -0400 In-Reply-To: <20180504025432.23451-9-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 3 May 2018 19:54:31 -0700 David Ahern wrote: > diff --git a/net/core/filter.c b/net/core/filter.c > index 6877426c23a6..cf0d27acf1d1 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c [...] > +static const struct bpf_func_proto bpf_xdp_fib_lookup_proto = { > + .func = bpf_xdp_fib_lookup, > + .gpl_only = true, Is it a deliberate choice to require BPF-progs using this helper to be GPL licensed? Asking as this seems to be the first network related helper with this requirement, while this is typical for tracing related helpers. > + .ret_type = RET_INTEGER, > + .arg1_type = ARG_PTR_TO_CTX, > + .arg2_type = ARG_PTR_TO_MEM, > + .arg3_type = ARG_CONST_SIZE, > + .arg4_type = ARG_ANYTHING, > +}; -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer