From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v10 2/4] net: Introduce generic failover module Date: Mon, 7 May 2018 16:59:11 -0700 Message-ID: <20180507165911.45b14c58@xeon-e3> References: <1525731046-10989-1-git-send-email-sridhar.samudrala@intel.com> <1525731046-10989-3-git-send-email-sridhar.samudrala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com To: Sridhar Samudrala Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:45915 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbeEGX7O (ORCPT ); Mon, 7 May 2018 19:59:14 -0400 Received: by mail-pg0-f67.google.com with SMTP id i29-v6so20329186pgn.12 for ; Mon, 07 May 2018 16:59:13 -0700 (PDT) In-Reply-To: <1525731046-10989-3-git-send-email-sridhar.samudrala@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", > + slave_dev->name, err); > + goto err_dev_open; > + } > + } > + > + netif_addr_lock_bh(failover_dev); > + dev_uc_sync_multiple(slave_dev, failover_dev); > + dev_uc_sync_multiple(slave_dev, failover_dev); > + netif_addr_unlock_bh(failover_dev); > + The order of these is backwards, you want to sync addresses before bringing up. Also, doing it this way does not allow udev/systemd the chance to rename VF devices. The complexity of this whole failover mechanism does not make life easier, more reliable, or safer for netvsc. I though that was the whole reason for having common code.