netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: netdev@vger.kernel.org, willemb@google.com, davem@davemloft.net
Subject: [net-next PATCH v3 1/6] udp: Record gso_segs when supporting UDP segmentation offload
Date: Mon, 07 May 2018 11:08:22 -0700	[thread overview]
Message-ID: <20180507180821.3486.68488.stgit@localhost.localdomain> (raw)
In-Reply-To: <20180507180310.3486.35994.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@intel.com>

We need to record the number of segments that will be generated when this
frame is segmented. The expectation is that if gso_size is set then
gso_segs is set as well. Without this some drivers such as ixgbe get
confused if they attempt to offload this as they record 0 segments for the
entire packet instead of the correct value.

Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 net/ipv4/udp.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index dd3102a37ef9..e07db83b311e 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -793,6 +793,8 @@ static int udp_send_skb(struct sk_buff *skb, struct flowi4 *fl4,
 
 		skb_shinfo(skb)->gso_size = cork->gso_size;
 		skb_shinfo(skb)->gso_type = SKB_GSO_UDP_L4;
+		skb_shinfo(skb)->gso_segs = DIV_ROUND_UP(len - sizeof(uh),
+							 cork->gso_size);
 		goto csum_partial;
 	}
 

  reply	other threads:[~2018-05-07 18:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 18:08 [net-next PATCH v3 0/6] Series short description Alexander Duyck
2018-05-07 18:08 ` Alexander Duyck [this message]
2018-05-07 18:08 ` [net-next PATCH v3 2/6] udp: Do not pass MSS as parameter to GSO segmentation Alexander Duyck
2018-05-07 18:08 ` [net-next PATCH v3 3/6] udp: Do not pass checksum as a " Alexander Duyck
2018-05-07 18:49   ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment Alexander Duyck
2018-05-07 18:27   ` Eric Dumazet
2018-05-07 18:57   ` Willem de Bruijn
2018-05-07 19:54     ` Willem de Bruijn
2018-05-07 19:59       ` Alexander Duyck
2018-05-07 20:10         ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 5/6] udp: Add support for software checksum and GSO_PARTIAL with GSO offload Alexander Duyck
2018-05-07 18:43   ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 6/6] udp: Do not copy destructor if one is not present Alexander Duyck
2018-05-07 18:25   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507180821.3486.68488.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).