From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given Date: Tue, 08 May 2018 20:14:49 -0400 (EDT) Message-ID: <20180508.201449.398803363821420826.davem@davemloft.net> References: <20180504152103.18152-1-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: antoine.tenart@bootlin.com Return-path: In-Reply-To: <20180504152103.18152-1-antoine.tenart@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Antoine Tenart Date: Fri, 4 May 2018 17:21:03 +0200 > When computing the bitrate using values read from an SFP module EEPROM, > we use the nominal BR plus BR,min and BR,max to determine the > boundaries. But in some cases BR,min and BR,max aren't provided, which > led the SFP code to end up having the nominal value for both the minimum > and maximum bitrate values. When using a passive cable, the nominal > value should be used as the maximum one, and there is no minimum one > so we should use 0. > > Signed-off-by: Antoine Tenart Applied, thank you.