From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss Date: Wed, 9 May 2018 10:31:44 -0700 Message-ID: <20180509103144.195e7494@xeon-e3> References: <20180507184333.32688-1-sthemmin@microsoft.com> <20180509082209.38fa4f43@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, dccp@vger.kernel.org, Stephen Hemminger To: Eric Dumazet Return-path: Received: from mail-pf0-f175.google.com ([209.85.192.175]:33856 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965405AbeEIRbq (ORCPT ); Wed, 9 May 2018 13:31:46 -0400 Received: by mail-pf0-f175.google.com with SMTP id a14so25989426pfi.1 for ; Wed, 09 May 2018 10:31:46 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 9 May 2018 10:18:23 -0700 Eric Dumazet wrote: > On 05/09/2018 08:22 AM, Stephen Hemminger wrote: > > > I am not sure if these patches are worth applying. > > The 'ss -s' command has had missing values since 2.4 kernel. > > And the first complaints came in only this year. > > > > Another alternative would be just to remove these fields from ss -s > > output and move on. > > > > Anyway your patches are not netns ready, so lets remove these fields from ss. > > Or you have to spend _much_ more time on writing and testing the kernel part. > > Thanks. The patches only expose the existing TCP socket accounting infrastructure. Several other pieces that sockstat has are not netns aware. That is a completely different problem.