From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
dccp@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss
Date: Wed, 9 May 2018 11:44:56 -0700 [thread overview]
Message-ID: <20180509114456.0303a026@xeon-e3> (raw)
In-Reply-To: <57fc8849-d1a4-4748-8780-bca3b0c7ca47@gmail.com>
On Wed, 9 May 2018 10:53:58 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On 05/09/2018 10:31 AM, Stephen Hemminger wrote:
> > On Wed, 9 May 2018 10:18:23 -0700
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> On 05/09/2018 08:22 AM, Stephen Hemminger wrote:
> >>
> >>> I am not sure if these patches are worth applying.
> >>> The 'ss -s' command has had missing values since 2.4 kernel.
> >>> And the first complaints came in only this year.
> >>>
> >>> Another alternative would be just to remove these fields from ss -s
> >>> output and move on.
> >>>
> >>
> >> Anyway your patches are not netns ready, so lets remove these fields from ss.
> >>
> >> Or you have to spend _much_ more time on writing and testing the kernel part.
> >>
> >> Thanks.
> >
> > The patches only expose the existing TCP socket accounting infrastructure.
> > Several other pieces that sockstat has are not netns aware.
> > That is a completely different problem.
>
>
> Adding a new field counting 'bounds ports' without being netns ready is a total mistake,
> as it is useless by current standards.
>
> The first thing that users will do is add proper netns support, with extra complexity in the kernel.
>
> So, instead of pushing some incomplete feature, trying to fool ourselves with a sentiment of 'small cost'
> that will later need another 100 lines of code in the kernel, please give us the complete picture.
>
> I am just saying, you can of course ignore my feedback.
The current TCP hashinfo should be moved into netns. The current method of scanning and matching
by net namespace is a scalability issue now.
next prev parent reply other threads:[~2018-05-09 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 18:43 [PATCH net-next v3 0/2] socket statistics for ss Stephen Hemminger
2018-05-07 18:43 ` [PATCH net-next v3 1/2] inet: add bound ports statistic Stephen Hemminger
2018-05-07 18:43 ` [PATCH net-next v3 2/2] socket: keep track of the number of sockets allocated Stephen Hemminger
2018-05-09 15:22 ` [PATCH net-next v3 0/2] socket statistics for ss Stephen Hemminger
2018-05-09 17:18 ` Eric Dumazet
2018-05-09 17:31 ` Stephen Hemminger
2018-05-09 17:53 ` Eric Dumazet
2018-05-09 18:44 ` Stephen Hemminger [this message]
2018-05-09 18:53 ` Eric Dumazet
2018-05-09 19:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509114456.0303a026@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).