From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss Date: Wed, 9 May 2018 11:44:56 -0700 Message-ID: <20180509114456.0303a026@xeon-e3> References: <20180507184333.32688-1-sthemmin@microsoft.com> <20180509082209.38fa4f43@xeon-e3> <20180509103144.195e7494@xeon-e3> <57fc8849-d1a4-4748-8780-bca3b0c7ca47@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, dccp@vger.kernel.org, Stephen Hemminger To: Eric Dumazet Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:44361 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964949AbeEISpA (ORCPT ); Wed, 9 May 2018 14:45:00 -0400 Received: by mail-pf0-f196.google.com with SMTP id q22so26060534pff.11 for ; Wed, 09 May 2018 11:45:00 -0700 (PDT) In-Reply-To: <57fc8849-d1a4-4748-8780-bca3b0c7ca47@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 9 May 2018 10:53:58 -0700 Eric Dumazet wrote: > On 05/09/2018 10:31 AM, Stephen Hemminger wrote: > > On Wed, 9 May 2018 10:18:23 -0700 > > Eric Dumazet wrote: > > > >> On 05/09/2018 08:22 AM, Stephen Hemminger wrote: > >> > >>> I am not sure if these patches are worth applying. > >>> The 'ss -s' command has had missing values since 2.4 kernel. > >>> And the first complaints came in only this year. > >>> > >>> Another alternative would be just to remove these fields from ss -s > >>> output and move on. > >>> > >> > >> Anyway your patches are not netns ready, so lets remove these fields from ss. > >> > >> Or you have to spend _much_ more time on writing and testing the kernel part. > >> > >> Thanks. > > > > The patches only expose the existing TCP socket accounting infrastructure. > > Several other pieces that sockstat has are not netns aware. > > That is a completely different problem. > > > Adding a new field counting 'bounds ports' without being netns ready is a total mistake, > as it is useless by current standards. > > The first thing that users will do is add proper netns support, with extra complexity in the kernel. > > So, instead of pushing some incomplete feature, trying to fool ourselves with a sentiment of 'small cost' > that will later need another 100 lines of code in the kernel, please give us the complete picture. > > I am just saying, you can of course ignore my feedback. The current TCP hashinfo should be moved into netns. The current method of scanning and matching by net namespace is a scalability issue now.