From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] tipc: eliminate KMSAN uninit-value in strcmp complaint Date: Thu, 10 May 2018 08:25:46 -0400 (EDT) Message-ID: <20180510.082546.2079660211607047825.davem@davemloft.net> References: <1525787046-5661-1-git-send-email-ying.xue@windriver.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, tipc-discussion@lists.sourceforge.net To: ying.xue@windriver.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:58772 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756741AbeEJMZs (ORCPT ); Thu, 10 May 2018 08:25:48 -0400 In-Reply-To: <1525787046-5661-1-git-send-email-ying.xue@windriver.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Ying Xue Date: Tue, 8 May 2018 21:44:06 +0800 > When we get link properties through netlink interface with > tipc_nl_node_get_link(), we don't validate TIPC_NLA_LINK_NAME > attribute at all, instead we directly use it. As a consequence, > KMSAN detected the TIPC_NLA_LINK_NAME attribute was an uninitialized > value, and then posted the following complaint: ... > To quiet the complaint, TIPC_NLA_LINK_NAME attribute has been > validated in tipc_nl_node_get_link() before it's used. > > Reported-by: syzbot+df0257c92ffd4fcc58cd@syzkaller.appspotmail.com > Signed-off-by: Ying Xue Applied, thanks.