From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
pieter.jansenvanvuuren@netronome.com
Subject: Re: [PATCH net] nfp: flower: remove headroom from max MTU calculation
Date: Thu, 10 May 2018 15:28:27 -0400 (EDT) [thread overview]
Message-ID: <20180510.152827.2297604674993831939.davem@davemloft.net> (raw)
In-Reply-To: <20180509071858.11124-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 9 May 2018 00:18:58 -0700
> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
>
> Since commit 29a5dcae2790 ("nfp: flower: offload phys port MTU change") we
> take encapsulation headroom into account when calculating the max allowed
> MTU. This is unnecessary as the max MTU advertised by firmware should have
> already accounted for encap headroom.
>
> Subtracting headroom twice brings the max MTU below what's necessary for
> some deployments.
>
> Fixes: 29a5dcae2790 ("nfp: flower: offload phys port MTU change")
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
> Reviewed-by: John Hurley <john.hurley@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
prev parent reply other threads:[~2018-05-10 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 7:18 [PATCH net] nfp: flower: remove headroom from max MTU calculation Jakub Kicinski
2018-05-10 19:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510.152827.2297604674993831939.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).