From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: flower: remove headroom from max MTU calculation Date: Thu, 10 May 2018 15:28:27 -0400 (EDT) Message-ID: <20180510.152827.2297604674993831939.davem@davemloft.net> References: <20180509071858.11124-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, pieter.jansenvanvuuren@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:36032 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbeEJT22 (ORCPT ); Thu, 10 May 2018 15:28:28 -0400 In-Reply-To: <20180509071858.11124-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Wed, 9 May 2018 00:18:58 -0700 > From: Pieter Jansen van Vuuren > > Since commit 29a5dcae2790 ("nfp: flower: offload phys port MTU change") we > take encapsulation headroom into account when calculating the max allowed > MTU. This is unnecessary as the max MTU advertised by firmware should have > already accounted for encap headroom. > > Subtracting headroom twice brings the max MTU below what's necessary for > some deployments. > > Fixes: 29a5dcae2790 ("nfp: flower: offload phys port MTU change") > Signed-off-by: Pieter Jansen van Vuuren > Reviewed-by: John Hurley > Reviewed-by: Jakub Kicinski Applied.