From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: cleanup Global Control 2 register Date: Thu, 10 May 2018 16:13:10 -0400 (EDT) Message-ID: <20180510.161310.1711109503750888571.davem@davemloft.net> References: <20180509153851.10207-1-vivien.didelot@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, f.fainelli@gmail.com To: vivien.didelot@savoirfairelinux.com Return-path: In-Reply-To: <20180509153851.10207-1-vivien.didelot@savoirfairelinux.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Vivien Didelot Date: Wed, 9 May 2018 11:38:48 -0400 > The mv88e6xxx driver still writes arbitrary values in the Global 1 > Control 2 register at setup, which layout differs a lot between chips. > This results in an inconsistent configuration, for example with the > Remote Management Unit (RMU). > > The first patch adds an operation for the Cascade Port bits, the second > patch sets the device number in the device mapping function and the > third patch adds an operation to correctly disable the RMU. Series applied.