netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net/core: correct the variable name in dev_ioctl() comment
@ 2018-05-10  3:01 Sun Lianwen
  2018-05-10 21:41 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sun Lianwen @ 2018-05-10  3:01 UTC (permalink / raw)
  To: davem; +Cc: netdev

The variable name is not "arg" but "ifr" in dev_ioctl()

Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
---
 net/core/dev_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
index a04e1e88bf3a..114e29053977 100644
--- a/net/core/dev_ioctl.c
+++ b/net/core/dev_ioctl.c
@@ -378,7 +378,7 @@ EXPORT_SYMBOL(dev_load);
  *	dev_ioctl	-	network device ioctl
  *	@net: the applicable net namespace
  *	@cmd: command to issue
- *	@arg: pointer to a struct ifreq in user space
+ *	@ifr: pointer to a struct ifreq in user space
  *
  *	Issue ioctl functions to devices. This is normally called by the
  *	user space syscall interfaces but can sometimes be useful for
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net/core: correct the variable name in dev_ioctl() comment
  2018-05-10  3:01 [PATCH net-next] net/core: correct the variable name in dev_ioctl() comment Sun Lianwen
@ 2018-05-10 21:41 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-05-10 21:41 UTC (permalink / raw)
  To: sunlw.fnst; +Cc: netdev

From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Date: Thu, 10 May 2018 11:01:20 +0800

> The variable name is not "arg" but "ifr" in dev_ioctl()
> 
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>

If you are going to touch this, fix it full by adding the need_copyout
variable to the comment as well.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-10 21:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-10  3:01 [PATCH net-next] net/core: correct the variable name in dev_ioctl() comment Sun Lianwen
2018-05-10 21:41 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).