Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: Ido Schimmel <idosch@mellanox.com>,
	mlxsw@mellanox.com, nikolay@cumulusnetworks.com,
	jiri@mellanox.com, petrm@mellanox.com, davem@davemloft.net
Subject: [PATCH net-next 1/4] net: bridge: Allow bridge master in br_vlan_get_info()
Date: Thu, 10 May 2018 13:13:03 +0300	[thread overview]
Message-ID: <20180510101306.4891-2-idosch@mellanox.com> (raw)
In-Reply-To: <20180510101306.4891-1-idosch@mellanox.com>

From: Petr Machata <petrm@mellanox.com>

Mirroring offload in mlxsw needs to check that a given VLAN is allowed
to ingress the bridge device. br_vlan_get_info() is the function that is
used for this, however currently it only supports bridge port devices.
Extend it to support bridge masters as well.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
---
 net/bridge/br_vlan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index df37a5137c25..dc832c0934c6 100644
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -1176,6 +1176,8 @@ int br_vlan_get_info(const struct net_device *dev, u16 vid,
 	p = br_port_get_check_rtnl(dev);
 	if (p)
 		vg = nbp_vlan_group(p);
+	else if (netif_is_bridge_master(dev))
+		vg = br_vlan_group(netdev_priv(dev));
 	else
 		return -EINVAL;
 
-- 
2.14.3

  reply	other threads:[~2018-05-10 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 10:13 [PATCH net-next 0/4] mlxsw: Support VLAN devices in mirroring offloads Ido Schimmel
2018-05-10 10:13 ` Ido Schimmel [this message]
2018-05-10 12:06   ` [PATCH net-next 1/4] net: bridge: Allow bridge master in br_vlan_get_info() Nikolay Aleksandrov
2018-05-10 10:13 ` [PATCH net-next 2/4] mlxsw: reg: Add MLXSW_REG_MPAT_SPAN_TYPE_REMOTE_ETH Ido Schimmel
2018-05-10 10:13 ` [PATCH net-next 3/4] mlxsw: spectrum_span: Support mirror-to-VLAN Ido Schimmel
2018-05-10 10:13 ` [PATCH net-next 4/4] mlxsw: spectrum_span: Support VLAN under mirror-to-gretap Ido Schimmel
2018-05-10 21:51 ` [PATCH net-next 0/4] mlxsw: Support VLAN devices in mirroring offloads David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510101306.4891-2-idosch@mellanox.com \
    --to=idosch@mellanox.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=petrm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox