From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH] mlxsw: core: Fix an error handling path in 'mlxsw_core_bus_device_register()' Date: Thu, 10 May 2018 14:58:21 +0300 Message-ID: <20180510115821.GA10270@splinter.mtl.com> References: <20180510112616.20508-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jiri@mellanox.com, idosch@mellanox.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Christophe JAILLET Return-path: Content-Disposition: inline In-Reply-To: <20180510112616.20508-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, May 10, 2018 at 01:26:16PM +0200, Christophe JAILLET wrote: > Resources are not freed in the reverse order of the allocation. > Labels are also mixed-up. > > Fix it and reorder code and labels in the error handling path of > 'mlxsw_core_bus_device_register()' > > Signed-off-by: Christophe JAILLET For net: Fixes: ef3116e5403e ("mlxsw: spectrum: Register KVD resources with devlink") Reviewed-by: Ido Schimmel Next time, please indicate the tree you're targeting as explained here: https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt And include a Fixes line as explained here: https://www.kernel.org/doc/Documentation/process/submitting-patches.rst Thanks!