From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] mlxsw: core: Fix an error handling path in
 \'mlxsw_core_bus_device_register()\'
Date: Thu, 10 May 2018 16:17:57 +0300
Message-ID: <20180510131756.3od32k2cdwjsepyv@mwanda>
References: <20180510124138.6yerbsfcl3abqtmq@mwanda>
 <2c5caff2-5ece-d07b-4df9-47a9ff24a86f@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Arkadi Sharshevsky <arkadis@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from aserp2120.oracle.com ([141.146.126.78]:49456 "EHLO
        aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757247AbeEJNSK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 10 May 2018 09:18:10 -0400
Content-Disposition: inline
In-Reply-To: <2c5caff2-5ece-d07b-4df9-47a9ff24a86f@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 10, 2018 at 04:08:22PM +0300, Arkadi Sharshevsky wrote:
> Hi Dan,
> 
> I will fix the error path. Regarding the goto label this is
> the convention in the driver.

There is no rule against learning from the past.

Or there might be... I don't know all the rules at Mellanox.

regards,
dan carpenter