* [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured
@ 2018-05-11 15:45 Jiri Pirko
2018-05-11 17:56 ` Cong Wang
2018-05-11 20:35 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2018-05-11 15:45 UTC (permalink / raw)
To: netdev; +Cc: davem, jhs, xiyou.wangcong, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
In case modules are not configured, error out when tp->ops is null
and prevent later null pointer dereference.
Fixes: 33a48927c193 ("sched: push TC filter protocol creation into a separate function")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
net/sched/cls_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index b66754f52a9f..963e4bf0aab8 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -152,8 +152,8 @@ static struct tcf_proto *tcf_proto_create(const char *kind, u32 protocol,
NL_SET_ERR_MSG(extack, "TC classifier not found");
err = -ENOENT;
}
- goto errout;
#endif
+ goto errout;
}
tp->classify = tp->ops->classify;
tp->protocol = protocol;
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured
2018-05-11 15:45 [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured Jiri Pirko
@ 2018-05-11 17:56 ` Cong Wang
2018-05-11 20:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2018-05-11 17:56 UTC (permalink / raw)
To: Jiri Pirko
Cc: Linux Kernel Network Developers, David Miller, Jamal Hadi Salim,
mlxsw
On Fri, May 11, 2018 at 8:45 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> In case modules are not configured, error out when tp->ops is null
> and prevent later null pointer dereference.
>
> Fixes: 33a48927c193 ("sched: push TC filter protocol creation into a separate function")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured
2018-05-11 15:45 [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured Jiri Pirko
2018-05-11 17:56 ` Cong Wang
@ 2018-05-11 20:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-11 20:35 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs, xiyou.wangcong, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 11 May 2018 17:45:32 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> In case modules are not configured, error out when tp->ops is null
> and prevent later null pointer dereference.
>
> Fixes: 33a48927c193 ("sched: push TC filter protocol creation into a separate function")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-11 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-11 15:45 [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured Jiri Pirko
2018-05-11 17:56 ` Cong Wang
2018-05-11 20:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).