From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next] samples/bpf: xdp_monitor, accept short options Date: Fri, 11 May 2018 18:31:25 +0200 Message-ID: <20180511183125.6b4f92e2@redhat.com> References: <20180511013751.4360-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , Alexei Starovoitov , "David S . Miller" , netdev@vger.kernel.org, brouer@redhat.com To: Prashant Bhole Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750950AbeEKQbc (ORCPT ); Fri, 11 May 2018 12:31:32 -0400 In-Reply-To: <20180511013751.4360-1-bhole_prashant_q7@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 11 May 2018 10:37:51 +0900 Prashant Bhole wrote: > updated optstring accept short options > > Signed-off-by: Prashant Bhole > --- > samples/bpf/xdp_monitor_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/bpf/xdp_monitor_user.c b/samples/bpf/xdp_monitor_user.c > index 894bc64c2cac..668511c77aaf 100644 > --- a/samples/bpf/xdp_monitor_user.c > +++ b/samples/bpf/xdp_monitor_user.c > @@ -594,7 +594,7 @@ int main(int argc, char **argv) > snprintf(bpf_obj_file, sizeof(bpf_obj_file), "%s_kern.o", argv[0]); > > /* Parse commands line args */ > - while ((opt = getopt_long(argc, argv, "h", > + while ((opt = getopt_long(argc, argv, "hDSs:", > long_options, &longindex)) != -1) { > switch (opt) { > case 'D': It was actually on purpose that I didn't add the short options, in-order to force people use those "self-documenting" long-options when they show the usage on public mailing lists or in blog-posts. If you want these short options, you also have to correct the "usage" function that state these are "internal" short-options. Notice the long options parsing done by getopt_long() allow you to only specify part of the string. Al-through, I can see --s is ambiguous. $ sudo ./xdp_monitor --s ./xdp_monitor: option '--s' is ambiguous; possibilities: '--stats' '--sec' -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer