From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: brouer@redhat.com, alexei.starovoitov@gmail.com,
daniel@iogearbox.net, oss-drivers@netronome.com,
netdev@vger.kernel.org, "Björn Töpel" <bjorn.topel@gmail.com>
Subject: Re: [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf
Date: Sat, 12 May 2018 10:39:06 +0200 [thread overview]
Message-ID: <20180512103906.0a3af54c@redhat.com> (raw)
In-Reply-To: <20180512001729.21634-1-jakub.kicinski@netronome.com>
On Fri, 11 May 2018 17:17:25 -0700
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> Following patches address build issues after recent move to libbpf.
> For out-of-tree builds we would see the following error:
>
> gcc: error: samples/bpf/../../tools/lib/bpf/libbpf.a: No such file or directory
>
> Mini-library called libbpf.h in samples is renamed to bpf_insn.h,
> using linux/filter.h seems not completely trivial since some samples
> get upset when order on include search path in changed. We do have
> to rename libbpf.h, however, because otherwise it's hard to reliably
> get to libbpf's header in out-of-tree builds.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Thank you for doing this... this mini-library also called libbpf.h have
confused me before, and I bet it will/would confuse others as well.
Glad to see it being renamed :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2018-05-12 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 0:17 [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 1/4] samples: bpf: include bpf/bpf.h instead of local libbpf.h Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 2/4] samples: bpf: rename libbpf.h to bpf_insn.h Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 3/4] samples: bpf: fix build after move to compiling full libbpf.a Jakub Kicinski
2018-05-12 19:38 ` Jakub Kicinski
2018-05-12 23:22 ` Daniel Borkmann
2018-05-14 19:12 ` Y Song
2018-05-14 20:47 ` Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 4/4] samples: bpf: move libbpf from object dependencies to libs Jakub Kicinski
2018-05-12 8:39 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512103906.0a3af54c@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).