From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf Date: Sat, 12 May 2018 10:39:06 +0200 Message-ID: <20180512103906.0a3af54c@redhat.com> References: <20180512001729.21634-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, alexei.starovoitov@gmail.com, daniel@iogearbox.net, oss-drivers@netronome.com, netdev@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFQ=?= =?UTF-8?B?w7ZwZWw=?= To: Jakub Kicinski Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34092 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750722AbeELIjN (ORCPT ); Sat, 12 May 2018 04:39:13 -0400 In-Reply-To: <20180512001729.21634-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 11 May 2018 17:17:25 -0700 Jakub Kicinski wrote: > Following patches address build issues after recent move to libbpf. > For out-of-tree builds we would see the following error: > > gcc: error: samples/bpf/../../tools/lib/bpf/libbpf.a: No such file or directory > > Mini-library called libbpf.h in samples is renamed to bpf_insn.h, > using linux/filter.h seems not completely trivial since some samples > get upset when order on include search path in changed. We do have > to rename libbpf.h, however, because otherwise it's hard to reliably > get to libbpf's header in out-of-tree builds. Acked-by: Jesper Dangaard Brouer Thank you for doing this... this mini-library also called libbpf.h have confused me before, and I bet it will/would confuse others as well. Glad to see it being renamed :-) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer