From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
"Björn Töpel" <bjorn.topel@gmail.com>
Subject: Re: [PATCH bpf-next 3/4] samples: bpf: fix build after move to compiling full libbpf.a
Date: Sat, 12 May 2018 12:38:05 -0700 [thread overview]
Message-ID: <20180512123757.7970f381@cakuba> (raw)
In-Reply-To: <20180512001729.21634-4-jakub.kicinski@netronome.com>
On Fri, 11 May 2018 17:17:28 -0700, Jakub Kicinski wrote:
> There are many ways users may compile samples, some of them got
> broken by commit 5f9380572b4b ("samples: bpf: compile and link
> against full libbpf"). Improve path resolution and make libbpf
> building a dependency of source files to force its build.
>
> Samples should now again build with any of:
> cd samples/bpf; make
> make samples/bpf
> make -C samples/bpf
> cd samples/bpf; make O=builddir
> make samples/bpf O=builddir
> make -C samples/bpf O=builddir
>
> Fixes: 5f9380572b4b ("samples: bpf: compile and link against full libbpf")
> Reported-by: Björn Töpel <bjorn.topel@gmail.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Unfortunately Björn reports this still doesn't fix the build for him.
Investigating further.
next prev parent reply other threads:[~2018-05-12 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 0:17 [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 1/4] samples: bpf: include bpf/bpf.h instead of local libbpf.h Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 2/4] samples: bpf: rename libbpf.h to bpf_insn.h Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 3/4] samples: bpf: fix build after move to compiling full libbpf.a Jakub Kicinski
2018-05-12 19:38 ` Jakub Kicinski [this message]
2018-05-12 23:22 ` Daniel Borkmann
2018-05-14 19:12 ` Y Song
2018-05-14 20:47 ` Jakub Kicinski
2018-05-12 0:17 ` [PATCH bpf-next 4/4] samples: bpf: move libbpf from object dependencies to libs Jakub Kicinski
2018-05-12 8:39 ` [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512123757.7970f381@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox