From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept
 Enhanced (cake) qdisc
Date: Sun, 13 May 2018 20:09:48 -0400 (EDT)
Message-ID: <20180513.200948.1658763899383204062.davem@davemloft.net>
References: <152578993399.4805.688094683770472380.stgit@alrua-kau>
        <152579005972.4805.2514975750552805066.stgit@alrua-kau>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: toke@toke.dk
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:51296 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750991AbeENAJx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 13 May 2018 20:09:53 -0400
In-Reply-To: <152579005972.4805.2514975750552805066.stgit@alrua-kau>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Tue, 08 May 2018 16:34:19 +0200

> +struct cake_flow {
> +	/* this stuff is all needed per-flow at dequeue time */
> +	struct sk_buff	  *head;
> +	struct sk_buff	  *tail;

Please do not invent your own SKB list handling mechanism.

Use a standard sk_buff_head.  If you don't need the locking etc., we
have interfaces like __skb_queue_head_init(), __skb_insert(), etc.
which will accomodate that.

> +static void cake_heapify(struct cake_sched_data *q, u16 i)
> +{
> +	static const u32 a = CAKE_MAX_TINS * CAKE_QUEUES;
> +	u32 m = i;
> +	u32 mb = cake_heap_get_backlog(q, m);

Please order local variables from longest to shortest line.

The entire submissions has this problem all over the place, please
correct it patch-series wide.

Thank you.