From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
steffen.klassert@secunet.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net] xfrm6: avoid potential infinite loop in _decode_session6()
Date: Sun, 13 May 2018 20:23:49 -0400 (EDT) [thread overview]
Message-ID: <20180513.202349.1985276646648462963.davem@davemloft.net> (raw)
In-Reply-To: <20180512094930.77801-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sat, 12 May 2018 02:49:30 -0700
> syzbot found a way to trigger an infinitie loop by overflowing
> @offset variable that has been forced to use u16 for some very
> obscure reason in the past.
>
> We probably want to look at NEXTHDR_FRAGMENT handling which looks
> wrong, in a separate patch.
>
> In net-next, we shall try to use skb_header_pointer() instead of
> pskb_may_pull().
...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Reported-by: syzbot+0053c8...@syzkaller.appspotmail.com
Steffen, I am assuming you will pick this up.
Thank you.
next prev parent reply other threads:[~2018-05-14 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 9:49 [PATCH net] xfrm6: avoid potential infinite loop in _decode_session6() Eric Dumazet
2018-05-14 0:23 ` David Miller [this message]
2018-05-14 8:41 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513.202349.1985276646648462963.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox